Am I right here?

Hi guys,

Simple circuit as shown.

Am I right in adding the two 1N4001 diodes to protect the LED's?

The LED's are 5Vr so I assume would breakdown with the 12V.
The 1N4001 diodes are 35Vrms

Thanks
Angie

**broken link removed**

Is the switch supposed to be reversing the polarity, so that LED1 lights one way, and LED2 lights with the opposite polarity?

If so, then you can do this with just one resistor, with the LEDs connected inverse-parallel, with no diodes. The conducting LED protects the reversed biased one. In fact, you can do it with a single RED-GREEN two-pin LED.

Yes, reversing polarity switch.

Ah, so I over-engineered

Thanks Mike