BoostC USART 18F

[AtomSoft]

Ok im having some trouble receiving from Hyper Terminal to my PIC18F1320.
Im using BoostC to program/

I can send data out with no problem... Here is my receive code:

void RxRecv(char &MyTmp)
{
    while(!pir1.RCIF);

        MyTmp = rcreg;
        Rs_Send(rcreg);
}

and this is how im calling it

    while(1)
    {
        char Tmp2 = 0x00;
        RxRecv(Tmp2);
    }

Now for some reason when i type a key in hyper terminal it wont work. But i have the same code in ASM and it works fine on same chip. Any thoughts?

 

[eng1]

The argument of the function RxRecv() looks wrong to me.
Does this work?

unsigned char MyTmp;

unsigned char RxRecv(){

    while(!PIR1.RCIF);
    return RCREG;

}

// ....

while(1){

    MyTmp = RxRecv();
    Rs_Send(MyTmp);

}

 

[Pommie]

I can send data out with no problem... Here is my receive code:

void RxRecv(char &MyTmp)
{
    while(!pir1.RCIF);

        MyTmp = rcreg;
        Rs_Send(rcreg);
}

Try changing it to void RxRecv(char *MyTmp) and your calling code to RxRecv(&Tmp2);

The (char *) tells the compiler to expect a pointer with the address of a char variable and &Tmp2 passes the address of the variable.

Mike.

 

[AtomSoft]

The actual issue is i cant seem to get passed the (bold):

void RxRecv(char *MyTmp)
{
    while(!pir1.RCIF);  //Not correctly checking Flag even with 
                        //a breakpoint i cant skip this

        *MyTmp = rcreg;
        Rs_Send(rcreg);
}

 

[eng1]

Did you set bit CREN, that enables the reception?

 

[AtomSoft]

yes here is my full code: (still nothing)

#include <p1320.h>
#pragma	CLOCK_FREQ 8000000

void Rs_Init()
{
    //RS Init.
    trisb = 0b00010010;
    portb = 0x00;
    spbrg = 0x0C;
    txsta.BRGH = 0;
    baudctl.BRG16 = 0;
    txsta.SYNC = 0;
    rcsta.SPEN = 1;
    rcsta.CREN = 1;
    txsta.TXEN = 1;
}

void Rs_Send (char tx_char)
{
    while(!pir1.TXIF);
    txreg = tx_char;
        
}

void puts(char *source)
{
	while (*source != 0) // wait until tx register is empty
	    Rs_Send(*source++);
        Rs_Send(0x0d);
        Rs_Send(0x0a);
}


void RxRecv(char *MyTmp)
{
    while(!pir1.RCIF);  //Not correctly checking Flag even with 
                        //a breakpoint i cant skip this

        *MyTmp = rcreg;
        Rs_Send(rcreg);
}


void main()
{
    //PIC Init.
    osccon.IRCF2 = 1; // 8Mhz Clock
    osccon.IRCF1 = 1;
    osccon.IRCF0 = 1;

    Rs_Init();    

    puts("Hello, world\r\n");
  
    while(1)
    {
        char Tmp2 = 0x00;
        RxRecv(&Tmp2);
    }
}

 

[eng1]

You did not configured the A/D channels, did you? Try adding this line at the begining of the main function:

ADCON1 = 0xFF;

 

[BeeBop]

Does this work?

char Tmp2 = 0x00;
while (1) {
      if (pir1.RCIF) {
         Tmp2 = rcreg;
         Rs_Send(Tmp2);
      } // end if
} // end while

Why not use an interrupt?

 

[AtomSoft]

You did not configured the A/D channels, did you? Try adding this line at the begining of the main function:

ADCON1 = 0xFF;

Thanks a bunch! this works now. I should have seen it in my asm code but i guess i was going to fast! thanks a lot.

 

[AtomSoft]

Full Code Everything WORKING ! 100%