I've built several versions of something similar, but a bit cruder and have used them up to 2 GHz for crude measurments with good results. The basic principle of this is sound, and the construction method looks OK. The ones that I've built before used 0402 sized components soldered to the end of a piece of coax and then were glued into a pen barrel along with a gold plated tip pulled from a BNC connector. Same basic idea, but I built both with and without the 50ohm termination and both functioned. In principle, the 50 ohm resistance is a better idea as it provides a correct termination for any reflections coming back from the instrument.
In using such a thing, it is important to realize that this is effectively a voltage probe. So, if you are using it with a spectrum analyzer that displays power, not voltage, you have to translate in your head using the known or guessed impedance at the point you are probing (Alternatively, some analyzers allow you to display voltage directly). If probing a circuit node that you know is 50 ohms, then this is easy, but if you can't estimate the node impedance of the point you are probing, then your guess about the accuracy of the displayed level will have greater error.