Program done but pic does not execute it !!

atferrari said:

Yuo say "code is good".

The fact that the compiler does compile it means that your wrote it the right way. It does not say that is hardware-wise correct.

You were asked if you could single-step it.

Simulation is in order to see if you are doing what is actually needed to get what you expect.

Click to expand...

how do i single step ?

absf said:

I converted your program to HiTech C and it works on the ISIS..


I also attached the isis sim and the hex file. You may try my hex file and see if it works on your ISIS circuit.

Allen

Click to expand...

Thanks for the program , but why it does not work with my original one , thats so bizzare .

BGAmodz said:

Thanks for the program , but why it does not work with my original one , thats so bizzare .

Click to expand...

Well, did you compare your original one with my converted C? And the changes I made on the ISIS circuit?

I inserted the "ADCON1 = 6" in my program which was missing in your program, without which my ISIS refuse to work. I also added resistors to MCLR and RA0 , as I have mentioned earlier, in order to make the simulator work. These addons are not optional.

You could also do single stepping as Ian has told you to and see if your program does work as you expected.

Allen

absf said:

Well, did you compare your original one with my converted C? And the changes I made on the ISIS circuit?

I inserted the "ADCON1 = 6" in my program which was missing in your program, without which my ISIS refuse to work. I also added resistors to MCLR and RA0 , as I have mentioned earlier, in order to make the simulator work. These addons are not optional.

You could also do single stepping as Ian has told you to and see if your program does work as you expected.

Allen

Click to expand...

how do i single step ??
and what is the meaning of ADCON1=6 ?

ADCON1 is the register that defines which PORTA pins are used for digital input/output and which are used by the A/D module.
As you are only using the port in digital IO mode, set ADCON1 to a value of either 0x06 or 0x07 which makes all the pins digital.
Read here
https://ww1.microchip.com/downloads/en/devicedoc/39582b.pdf (130 page REGISTER 11-2)

Single stepping through the code in Isis lets you see the code line by line... On the bottom left there are the "Run", "Pause" and "stop" simulator controls....Once you "Pause" the simulation, you can open the code window and step through your code to see where mistakes are...

BGAmodz said:

how do i single step ?

Click to expand...

As Ian says, by simulating.

Since you never did it before, write a very simple program and learn how to simulate it, by single-stepping, that is, going step by step through it, to see how the registers change as per the actual code.

Once you understand what simulation is and what you are doing (that is, where to look after each step), do the same with the code that you expect to work.

Additional suggestion: whatever you do, always test one additional routine at a time.

The first time I heard the expression "divide and conquer" I believed that they were just words. Wrong I was! If something fails, it is, most probably, in the last section of code that you added. Easy to identify and correct. That suggestion should be carved in stone at the main square.

Ian Rogers said:

Single stepping through the code in Isis lets you see the code line by line... On the bottom left there are the "Run", "Pause" and "stop" simulator controls....Once you "Pause" the simulation, you can open the code window and step through your code to see where mistakes are...

Click to expand...

I will see that