Will this code work propertly?

Beginner0001 · Feb 22, 2021

I have 4 switches and 4 LEDs. I want to turn off the first LED with the first switch, the second one with the second switch, and so on. When I turn off the switch, LED should turn on. All switches connected to PORTA, all LEDs to PORTB. Initially, all LEDs are on. Will this code do the job?

Code:

PORTB=0b00001111;
   
    if (PINA & (1<<n))
    {
        PORTB = PORTB & ~(1 << n)
    }
    else
    {
        PORTB = PORTB | (1 << n);
    }

Pommie · Feb 22, 2021

It will work if,
The TRIS registers are setup correctly.
Pullup resistors are on port A or the internal pullups are on. And, the switch connects the port pin to GND.
Analogue is turned off.
Anything else (osc etc.) required is setup correctly.

Mike.

Beginner0001 · Feb 24, 2021

The TRIS registers are setup correctly.
Pullup resistors are on port A or the internal pullups are on. And, the switch connects the port pin to GND.
Analogue is turned off.

This is the way all four switches and LEDs are connected.

Ian Rogers · Feb 24, 2021

Beginner0001 said:
PORTB = PORTB | (1 << n);

Whats n??

Beginner0001 · Feb 24, 2021

Ian Rogers said:
Whats n??

That's the number of pin. I forgot to add a function.

Code:

static void LED(uint8_t n)
{
    PORTB=0b00001111;
    
    if (PINA & (1<<n)==1)
    {
        PORTB = PORTB & ~(1 << n);
    }
    else
    {
        PORTB = PORTB | (1 << n);
    }
}

Will this code work propertly?

Beginner0001

New Member

Pommie

Well-Known Member

Beginner0001

New Member

Ian Rogers

User Extraordinaire

Beginner0001

New Member

Similar threads

Will this code work propertly?

Beginner0001

New Member

Pommie

Well-Known Member

Beginner0001

New Member

Ian Rogers

User Extraordinaire

Beginner0001

New Member

Similar threads

Privacy & Transparency

Privacy & Transparency