Add GPS/PARSE to 8xSERVO-MOTOR CODE in Oshonsoft

[camerart]

Hi,
Here is CODE for 18F4431 8xCH SERVO-MOTOR CODE using a shift register: https://www.electro-tech-online.com/threads/oshonsoft-interrupt-parse.159316/

Add GPS and PARSE CODE to the above CODE, in the same way.

Camerart

 

[Pommie]

Where should I put the PARSE and rest of the CODE?

Put it in the if isDone test, I.E.

  If isDone then
    'deal with the received sentence here
    'This code can be any length but ideally less than 20mS
    isDone=0
  Endif

This is at the end of the code that moves the servos.
Note: the isDone=0 line will allow the ISR to get the next line so should be at the end of the parse code.

Mike.

 

[Pommie]

Actually, put the parse code where indicated and the rest of the code (whatever that is), after the if isDone code,
I.E.

  If isDone then
    'deal with the received sentence here
    'This code can be any length but ideally less than 20mS
    isDone=0
  Endif
  'other code here.
Wend

Mike.

 

[Pommie]

Note, 20mS seems like a small amount of time but it's 160,000 instruction cycles - that's a long time.

Mike.

 

[Pommie]

Also note, the If isDone code only gets executed once every 20mS but the code could be changed so it executes much more often.

Mike.

 

[camerart]

Actually, put the parse code where indicated and the rest of the code (whatever that is), after the if isDone code,
I.E.

  If isDone then
    'deal with the received sentence here
    'This code can be any length but ideally less than 20mS
    isDone=0
  Endif
  'other code here.
Wend

Mike.

Hi m,

'other code here.

Will compare the peripheral DATA from this PIC with the transmitted RC DATA from BASE then make a calculation, to controll the MOTORS/SERVOS.
Onwards and upwards.
C

 

[camerart]

Also note, the If isDone code only gets executed once every 20mS but the code could be changed so it executes much more often.

Mike.

Hi m,
I'm trying to keep up, but the GPS sentences arrive each 250ms and the SERVO use their time, so I presume there is enough time, but I don't know how I test for it, except perhaps the Analyser. This is a new speed for me to soak in.
C.

 

[camerart]

Hi M,
Looking at your CODE, before HIGH INTERRUPT, there are tabs and after 3x spaces = 1 tab.
So it appears that you're sending some spaces and some tabs.
C

 

[Pommie]

I thought the GPS sentence arrived 5 times per second so every 200mS. A sentence (if a full sentence) will take 80mS (or less) to arrive, worst case 20mS will elapse before it's parsed, that gives 100mS to parse the sentence (or we can take longer and miss a sentence) - the servos will stop moving if it takes 100mS to parse but that's not a problem as the movement is only a demonstration.

Note, human reaction time is generally accepted to be 0.2S = 200mS so we're still doing stuff faster than any human can.

Mike.

 

[Pommie]

Hi M,
Looking at your CODE, before HIGH INTERRUPT, there are tabs and after 3x spaces = 1 tab.
So it appears that you're sending some spaces and some tabs.
C

You're right, not sure why but attached is a space only version (I hope),

Mike.
Edit, all tabs should be two spaces.

 

[camerart]

You're right, not sure why but attached is a space only version (I hope),

Mike.
Edit, all tabs should be two spaces.

Hi M,
It all needs to be TABS, for Osh.
I've done it manually.
C

 

[camerart]

I thought the GPS sentence arrived 5 times per second so every 200mS. A sentence (if a full sentence) will take 80mS (or less) to arrive, worst case 20mS will elapse before it's parsed, that gives 100mS to parse the sentence (or we can take longer and miss a sentence) - the servos will stop moving if it takes 100mS to parse but that's not a problem as the movement is only a demonstration.

Note, human reaction time is generally accepted to be 0.2S = 200mS so we're still doing stuff faster than any human can.

Mike.

Hi M,
Yes, they arrive 5/sec, let's hope it all fits in, I'm about to set up 'live' tests, but got to write some CODE to make it do something. (Not sure whatthat will look like?)

As for reaction time, the craft flying at 30MPH may be more relevant.
C

 

[Pommie]

If you load the file into Notepad++ you can do a search and replace two spaces with a tab. I'll make sure in future all indenting is tabs only.

Mike.

 

[Pommie]

the craft flying at 30MPH may be more relevant.

I fly aircraft at 115MPH (100Kt) without any problem.

Mike.

 

[camerart]

If you load the file into Notepad++ you can do a search and replace two spaces with a tab. I'll make sure in future all indenting is tabs only.

Mike.

Hi M,
Ok, tabs it is
I've idented it myself in OSH, which I find easier.
Chees, C

 

[camerart]

I fly aircraft at 115MPH (100Kt) without any problem.

Mike.

Hi M,
Ah yes but I'm not controlling you

EDIT: Well done on the flying, I'm envious.
C

 

[Pommie]

Somehow, a line got added to a remark and so is missing,

Attached is the code with the line.

Mike.

 

[camerart]

Somehow, a line got added to a remark and so is missing,

Attached is the code with the line.

Mike.

Hi M,
I haven't got used to it yet, but in SIM, I can send an NMEA sentence see BUFF, and READ the first CHAR which is '$'
And my test LEDS are flashing too.
Not forgetting it's all TABBED.

Can you tell me what actually goes in
'adjust servo positions here
'deal with the received sentence here
'other code here.

Well done, thanks.
C

 

[Pommie]

The code in the while 1 loop is just to move the servos back and forth to test the servo ISR code.
Once finished the servo exercising code won't be there and instead will be the parse code and the result of that parsing will set the servo positions.
In the 'deal with the received sentence here
will go the code to parse the sentence as we now have a full sentence.
In #59 you asked,

Where should I put the PARSE and rest of the CODE?

I don't know what "the rest of the code" is but it goes where the comment 'other code here. is.

The idea is that it'll wizz around in the while, wend loop doing nothing until something needs to happen, if isDone gets set then a complete sentence has been received and can be parsed and used to set the servo positions (and isDone set back to zero so the ISR will fetch the next sentence). If something else needs to happen then it needs a way to know it needs to happen - i'm guessing this is the "rest of the CODE" mentioned above.

Note, the while, wend loop is the same as your main: goto main loop just more accepted as good coding practice.

Mike.

 

[camerart]

The code in the while 1 loop is just to move the servos back and forth to test the servo ISR code.
Once finished the servo exercising code won't be there and instead will be the parse code and the result of that parsing will set the servo positions.
In the 'deal with the received sentence here
will go the code to parse the sentence as we now have a full sentence.
In #59 you asked,

I don't know what "the rest of the code" is but it goes where the comment 'other code here. is.

The idea is that it'll wizz around in the while, wend loop doing nothing until something needs to happen, if isDone gets set then a complete sentence has been received and can be parsed and used to set the servo positions (and isDone set back to zero so the ISR will fetch the next sentence). If something else needs to happen then it needs a way to know it needs to happen - i'm guessing this is the "rest of the CODE" mentioned above.

Note, the while, wend loop is the same as your main: goto main loop just more accepted as good coding practice.

Mike.

Hi M,
REMOTE=PIC4
In #44 and the GPS CODE under '-------- PARSE UTILITIES -------------------------
is the GPS PARSE section. This extracts the TIME, LAT, LON from the REMOTE GPS.

Regarding only the Location:
The "rest of the CODE" is the calculations etc, which will be pages of CODE. e,g, comparisons, and the amount of movement to make. (As mentioned, I haven't given it much thought, untill all of the peripherals are working)

'Live' the SERVO moves FOR/REV and I've played with the speed settings. I undertsand that the FOR/REV section will be replaced by actual MOVE numbers.
C

 

[camerart]

Deleted